Skip to content

MAINT: remove %matplotlib inline and contents directives #313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 12, 2024
Merged

Conversation

mmcky
Copy link
Contributor

@mmcky mmcky commented Jun 11, 2024

This PR

  • removes %matplotlib inline and associated figsize settings
  • removes contents directives as not needed
  • validate the preview visually (spot checking)

@mmcky
Copy link
Contributor Author

mmcky commented Jun 11, 2024

  • confirm linkchecker are false positives

Copy link

@github-actions github-actions bot temporarily deployed to pull request June 11, 2024 05:23 Inactive
@mmcky
Copy link
Contributor Author

mmcky commented Jun 11, 2024

@jstac I think this is looking good.

@jstac
Copy link
Contributor

jstac commented Jun 12, 2024

Many thanks @mmcky . If you think it's necessary please get another set of eyes to review. Otherwise please go ahead and merge.

@mmcky
Copy link
Contributor Author

mmcky commented Jun 12, 2024

thanks @jstac I have done quite a few spot checks so I will merge.

@mmcky mmcky merged commit 1a87942 into main Jun 12, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants